extra multicast/unicast predicates#114
Conversation
|
@HoneyryderChuck What use cases do you have in mind for In particular, I'm not sure about the behavior of According to RFC 4291, all IPv6 addresses except Unspecified ( However, there is no corresponding definition of "Global Unicast" for IPv4, so In the current implementation of this pull request, IPv4 addresses that are not globally reachable, such as Private addresses (e.g. IPAddr.new("10.0.0.1").global_unicast?
# => trueIs this behavior intentional? If so, could you explain the rationale behind it? |
|
@taketo1113 thx for the reply!
I linked to the ruby implementation of the network package for the CEL language, and this particular patch is to allow a more standard and efficient way of implementing the IP package by moving the more general-purpose methods to the stdlib (just like in go's case, where these methods are part of the net.ip package.
Indeed the RFCs aren't very clear about this. FWIW I took my definition from go's net.ip impl (relevant parts: "...with the exception of IPv4 directed broadcast addresses. It returns true even if ip is in IPv4 private address space or local IPv6 unicast address space", the last part also addresses one other question in the paragraph below). |
taketo1113
left a comment
taketo1113
left a comment
There was a problem hiding this comment.
@HoneyryderChuck Thanks for the additional context.
I also looked at Go's implementation for reference.
However, there has been discussion about the behavior of net.IP.IsGlobalUnicast, particularly regarding IPv4 private addresses.
I also find it unintuitive for global_unicast? to return true for IPv4 private addresses.
If we introduce global_unicast? with this behavior, changing it later would create compatibility issues. For that reason, I don't think we should add global_unicast? at this point.
On the other hand, I think multicast? and link_local_multicast? are reasonable additions.
Could you update this PR to include only those two methods?
This adds the following predicate methods to IPAddr objects: * `#multicast?`: whether the ip address is multicast * `#link_local_multicast?`: whether the ip address is a link-local multicast it also alias `IPAddr#link_local?` as `IPAddr#link_local_unicast?`, which is more accurate (whether the original should be deprecated is probably a separate discussion).
HoneyryderChuck
force-pushed
the
multicast-predicates
branch
from
7b705e9 to
332ae1f
Compare
|
@taketo1113 done. I still think that a |
2 participants
This adds the following predicate methods to IPAddr objects:
#multicast?: whether the ip address is multicast#link_local_multicast?: whether the ip address is a link-local multicast#global_unicast?: whetther the ip address is a global unicastit also alias
IPAddr#link_local?asIPAddr#link_local_unicast?, which is more accurate (whether the original should be deprecated is probably a separate discussion).The motivation for adding these methods was to upstream these predicates from cel which have a broader meaning in the context of IP addressing, and maybe be applied in other contexts.